D16366: Fix crash with icon dialog

2018-10-22 Thread Christoph Feck
cfeck abandoned this revision. cfeck added a comment. Good spot, and this is already fixed, but unfortunately was too late for the 5.51 tag. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16366 To: cfeck, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, #f

D16366: Fix crash with icon dialog

2018-10-21 Thread Anthony Fieroni
anthonyfieroni added a comment. https://phabricator.kde.org/source/kiconthemes/browse/master/src/kicondialog.cpp;fea52a4f204fd44d9a45e78a663964c326687e33$419 It should be const QString fileName2 = path2.mid(path2.lastIndexOf(QLatin1Char('/')) + 1); no? REPOSITORY R302 KIconTh

D16366: Fix crash with icon dialog

2018-10-21 Thread Christoph Feck
cfeck changed the visibility from "Only User: cfeck (Christoph Feck)" to "Public (No Login Required)". Herald added a subscriber: kde-frameworks-devel. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16366 To: cfeck, #frameworks Cc: kde-frameworks-devel, #frameworks