D16370: KTextEditor : syntax definition priority UI usability

2018-11-25 Thread René J . V . Bertin
rjvbb added a comment. > Allowing negative prios makes sense. Yes, they do make life a bit more bearable but aren't the ultimate solution either, at least not on Mac. The other day I had to work my way through the entire list to set a whole bunch of positive priorities (which I never

D16370: KTextEditor : syntax definition priority UI usability

2018-11-25 Thread René J . V . Bertin
This revision was automatically updated to reflect the committed changes. Closed by commit R39:4009bc1e919d: Allow negative syntax definition priorities. (authored by rjvbb). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16370?vs=45380=46185 REVISION

D16370: KTextEditor : syntax definition priority UI usability

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think we merge the change here now. The tooltip is no real issue, we can try to consolidate what-this-tooltip-inline help an other time if somebody has interest. Allowing negative

D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread Nathaniel Graham
ngraham added a comment. FWIW, inline "what's this" help is something we're considering removing altogether for a variety of reasons (T9986 ), so I would prefer to ensure user-friendliness via an intuitive UI, tooltips, and non-inline documentation. Often

D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread René J . V . Bertin
rjvbb added a comment. > I would prefer to set this in the ui file: The maximum is already set to 99. Of course. FWIW, I decided against it because my approach ensures the range is always symmetric and esp. because the comment makes it less likely that someone will clamp the minimum

D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread Dominik Haumann
dhaumann added subscribers: ngraham, dhaumann. dhaumann added inline comments. INLINE COMMENTS > katemodeconfigpage.cpp:95 > +// having to increase the priority of (all) those definitions. > +ui->sbPriority->setMinimum(-ui->sbPriority->maximum()); > +// make the context help a bit

D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread René J . V . Bertin
rjvbb added a comment. > For the tooltip stuff: I am not sure if that is not inconsistent with the remaining stuff on these pages. Is there a platform-agnostic way to trigger the display of the "what's this" pop-up? If so a reminder of that could be shown somewhere, somehow?

D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread Christoph Cullmann
cullmann added a comment. +1 for the negative priority idea, might help some people. For the tooltip stuff: I am not sure if that is not inconsistent with the remaining stuff on these pages. Other opinions? REPOSITORY R39 KTextEditor REVISION DETAIL

D16370: KTextEditor : syntax definition priority UI usability

2018-10-22 Thread René J . V . Bertin
rjvbb created this revision. rjvbb added a reviewer: KTextEditor. rjvbb added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added a subscriber: kwrite-devel. rjvbb requested review of this revision. REVISION SUMMARY This implements 2 ideas I evoked in a blog post