D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Christoph Cullmann
cullmann closed this revision.
cullmann added a comment.


  Hmpf, arc failed :/
  
  But the stuff is in at least:
  
  Git commit e07306d9c22f6426d6b50287eee532555d74ac75 by Christoph Cullmann.
  Committed on 27/10/2018 at 14:36.
  Pushed by cullmann into branch 'master'.
  
  add test file + remove no longer existing instructions reference from xml
  
  A  +52   -0autotests/folding/test.rexx.fold
  A  +59   -0autotests/html/test.rexx.html
  A  +52   -0autotests/input/test.rexx
  A  +52   -0autotests/reference/test.rexx.ref
  M  +158  -93   data/syntax/rexx.xml
  
  
https://commits.kde.org/syntax-highlighting/e07306d9c22f6426d6b50287eee532555d74ac75

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the test file, I fixed the no longer existing ref
  
  
  
  and pushed the stuff!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young
phily updated this revision to Diff 44283.
phily added a comment.


  Removed typo in test script

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44282=44283

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young
phily updated this revision to Diff 44282.
phily added a comment.


  Did not include the syntax file itself in my last update, now the diff 
includes both.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44281=44282

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young
phily updated this revision to Diff 44281.
phily added a comment.


  Added test file to autotests/input/test.rexx as well as upgrading the version 
number

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44180=44281

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-25 Thread Christoph Cullmann
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, nice that you take care of fixing these issues.
  
  Two small things that could be improved:
  
  1. the version="2" needs to be bumped to 3
  2. there should be some unit test for the highlighting, you can put some test 
file into autotests/input (e.g. test.rex) this will make it much easier to keep 
this in a OK state in the future
  
  If you need more pointers on the testing, just ping us here, thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16414: Changes to REXX syntax highlighting

2018-10-24 Thread Phil Young
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.

REVISION SUMMARY
  The rexx syntax highlighting was incomplete. It was missing keywords, sub 
keywords and control flow keywords.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann