D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-11-01 Thread Christoph Cullmann
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a2032c52bf1b: Creating new syntax highlighting file for 
Job Control Language (JCL) (authored by phily, committed by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16415?vs=44457=44648#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44457=44648

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/folding/test.jcl.fold
  autotests/html/test.jcl.html
  autotests/input/test.jcl
  autotests/reference/test.jcl.ref
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-11-01 Thread Christoph Cullmann
cullmann added a comment.


  Merged ;=)
  
  Git commit a2032c52bf1b5ced774c2f58994aaeb4d233f25a by Christoph Cullmann, on 
behalf of Phil Young.
  Committed on 01/11/2018 at 15:54.
  Pushed by cullmann into branch 'master'.
  
  Creating new syntax highlighting file for Job Control Language (JCL)
  
  Differential Revision: https://phabricator.kde.org/D16415
  
  A  +43   -0autotests/folding/test.jcl.fold
  A  +50   -0autotests/html/test.jcl.html
  A  +43   -0autotests/input/test.jcl
  A  +43   -0autotests/reference/test.jcl.ref
  A  +170  -0data/syntax/jcl.xml
  
  
https://commits.kde.org/syntax-highlighting/a2032c52bf1b5ced774c2f58994aaeb4d233f25a

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-11-01 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.


  nice, thanks, will merge this!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-29 Thread Phil Young
phily updated this revision to Diff 44457.
phily added a comment.


  - Added JCL test program as well as fixing recommendations (no hard coded 
colors)
  - Added new highlighting of steps (vs program options)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44454=44457

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/input/test.jcl
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-29 Thread Phil Young
phily updated this revision to Diff 44454.
phily added a comment.


  Adding test file for JCL and making removing hard coded colors.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44277=44454

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/input/test.jcl
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-27 Thread Christoph Cullmann
cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-27 Thread Christoph Cullmann
cullmann added a comment.


  Hi, could one remove the two hard-coded colors and just use a different 
builtin defStyleNum?
  
  Beside that, have you some small example script that we could add as 
auto-test?
  
  e.g. something perhaps a bit larger than the snippets I can find on
  
  https://en.wikipedia.org/wiki/Job_Control_Language
  
  (and that has no license issues)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-26 Thread Phil Young
phily marked an inline comment as done.
phily added a comment.


  Thank you for the feedback. I've gone and updated the syntax file to explain 
what JCL is and remove the `^` from the regex. Thank you for the suggestions.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44277.
phily marked an inline comment as done.
phily added a comment.


  Making changes based on reviewer comments.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44181=44277

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-25 Thread Dominik Haumann
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Please add a small test file and explain what this highlighting language is 
used for :)

INLINE COMMENTS

> jcl.xml:3
> +
> + extensions="*.JCL;*.jcl" mimetype="">
> +  

kateversion="5.0" and license="MIT"

> jcl.xml:128
> +
> + String="^((?!\/\/\*).*)(\/\/).*?(?=\s)"/> 
> + String="^(?!\/\/).*"/>

Use column="0" and remove leading ^. Or do you mean firstNonSpace="true"?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars


D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-24 Thread Phil Young
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.

REVISION SUMMARY
  There is currently no support for JCL (Job Control Language) syntax 
highlighting. This XML file adds that support.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann