D16421: Improve emblem contrast, legibility and consistency

2019-01-06 Thread Nathaniel Graham
ngraham added a comment. Looks great to me! I guess it really is true that aesthetics are subjective. :) But it wasn't just about that. Check out the list of bugs this patch fixed. This was not just because we though ti looked prettier but also because the old emblems were much

D16421: Improve emblem contrast, legibility and consistency

2019-01-06 Thread Safa Alfulaij
safaalfulaij added a comment. mmm, sorry. I saw this today and I just took a minute to understand it. How does this looks consistent with the theme, or even nice (really sorry)? Please teach me. Thank you. F6529631: Screenshot_٢٠١٩٠١٠٦_١٣١٠٠٤.png

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg, ngraham Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks fantastic. Fabulous work. REPOSITORY R266 Breeze Icons BRANCH emblem-outlines (branched from master) REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg,

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Noah Davis
ndavis updated this revision to Diff 44410. ndavis added a comment. Add emblem-readonly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44313=44410 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis added a comment. In D16421#349331 , @ngraham wrote: > Thanks for the updates. I know it's a PITA, but would you mind updating the image in the Summary section? Done. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44313. ndavis added a comment. Add 16 and 22 px versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44308=44313 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44308. ndavis added a comment. Add dark versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44304=44308 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Nathaniel Graham
ngraham added a comment. Thanks for the updates. I know it's a PITA, but would you mind updating the image in the Summary section? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg,

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44304. ndavis added a comment. Improve arrow visibility on vcs emblems Add emblem-encrypted-locked Change emblem-locked back to orange REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44248=44304 BRANCH

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349083 , @ngraham wrote: > In D16421#349082 , @ndavis wrote: > > > In D16421#349081 , @ngraham wrote: > > > > > This

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#349082 , @ndavis wrote: > In D16421#349081 , @ngraham wrote: > > > This would all require some additional changes in Dolphin and Folder view, of course. > >

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349081 , @ngraham wrote: > This would all require some additional changes in Dolphin and Folder view, of course. So should I change `emblem-added` and `emblem-remove` back to their original colors? It

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#349080 , @ndavis wrote: > Something just occurred to me: Why do we use emblems as if they were action buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and `list-remove` instead of

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Something just occurred to me: Why do we use emblems as if they were action buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and `list-remove` instead of `emblem-added` and `emblem-remove`? REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#349075 , @bruns wrote: > There may also be a conceptual issue here - previously, the `emblem-locked` which is used for unaccessible (e.g. root owned) files was a lock with orange background, now it is green.

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349075 , @bruns wrote: > @ndavis - can you upload the `git format-patch -1` output somewhere (temporary)? https://hastebin.com/egepiwurab.diff > There may also be a conceptual issue here -

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#349072 , @ngraham wrote: > After manual application, the alignment is perfect for me too. So that's not a blocker; must be some local issye on your end, @ndavis. I think we're really close (or ready?) to being

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. After manual application, the alignment is perfect for me too. So that's not a blocker; must be some local issye on your end, @ndavis. I think we're really close (or ready?) to being able to land this! @bruns, are your comments about the question mark a blocker, or

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348960 , @ngraham wrote: > I wish I could test but I have not gotten the patch to apply so far. Did `arc apply D16421` work for you, or did you have to apply it by hand? No, I just copied a few of the

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#348959 , @bruns wrote: > Tried to reproduce it here, but for me the bottom-right emblem just renders fine here: > > F6363939: Unpatched_locked_link_48.png I

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348866 , @bruns wrote: > In D16421#348860 , @ndavis wrote: > > > The other issue with using a font based question mark is I also have to use that for the 8px icon

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348860 , @ndavis wrote: > The other issue with using a font based question mark is I also have to use that for the 8px icon if I want consistency. There is nothing wrong with using the font outline as a

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348857 , @bruns wrote: > In D16421#348826 , @ndavis wrote: > > > I could, but then I'm running into this issue: T9898 > > >

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348826 , @ndavis wrote: > I could, but then I'm running into this issue: T9898 > > I made that task when I was trying to come up with a more legible style for

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Slight change to make the 16 and 22 px icons look more like the 8px icon: F6363210: Screenshot_20181026_072203.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc:

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis updated this revision to Diff 44248. ndavis added a comment. Widen the circular portion of 16/22 px emblem-question icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44230=44248 BRANCH emblem-outlines (branched from master)

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348825 , @bruns wrote: > In D16421#348664 , @ndavis wrote: > > > In D16421#348594 , @ngraham wrote: > > > > > Now

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348664 , @ndavis wrote: > In D16421#348594 , @ngraham wrote: > > > Now that I stare at the summary graphics again, the white question mark looks a bit wispy and

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44230. ndavis added a comment. Make emblem-question symbol thicker REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44211=44230 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348702 , @ngraham wrote: > Does this problem still happen after you delete your icon cache? (`rm ~/.cache/icon-cache.kcache`) Yes. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348664 , @ndavis wrote: > How is this? > F6356555: Screenshot_20181025_193720.png Much better! That looks great. In D16421#348675

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348594 , @ngraham wrote: > Now that I stare at the summary graphics again, the white question mark looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other than that, everything looks

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its original bounds respected and results in it being drawn too high. Either I missed

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. Now that I stare at the summary graphics again, the white question mark looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other than that, everything looks pretty much perfect to me. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44211. ndavis added a comment. Change style of emblem-symbolic-link at 22px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44210=44211 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348516 , @ndavis wrote: > F6350488: Screenshot_20181025_100526.png //Perfect!// REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348513 , @bruns wrote: > The center link looks slightly too heavy, but imho still better. Might be possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, it should not make it too fuzzy.

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. In D16421#348507 , @ndavis wrote: > In D16421#348504 , @bruns wrote: > > > In D16421#348502 , @ndavis wrote: > > > > > Also,

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348507 , @ndavis wrote: > F6350381: Screenshot_20181025_095315.png Good! How about making the center link a tiny bit thinner? I'll look into the code in

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44210. ndavis added a comment. Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44201=44210 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348506 , @ngraham wrote: > In D16421#348502 , @ndavis wrote: > > > F6350185: Screenshot_20181025_093827.png > > F6350193:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348502 , @ndavis wrote: > F6350185: Screenshot_20181025_093827.png > F6350193: Screenshot_20181025_093800.png +1,

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. BTW, +1 for all the icons! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348487 , @bruns wrote: > Can you try the following: > > - Make the center link solid and narower (e.g. 2px height for the 16px one) > - Reduce the height of the right and left links Like this?

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. Can you try the following: - Make the center link solid and narower (e.g. 2px height for the 16px one) - Reduce the height of the right and left links REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. Here are what the changes look like: 8px symlink emblem, 16px emblem-remove: F6349477: Screenshot_20181025_041309.png Pretty crowded. 16px symlink emblem, 16px emblem-remove: F6349480:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44201. ndavis added a comment. Change emblem-remove color to Plasma Blue, Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44194=44201 BRANCH emblem-outlines

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Nathaniel Graham
ngraham added a comment. In D16421#348381 , @ndavis wrote: > Here's how that looks: F6349192: Screenshot_20181024_234540.png Looks good to me! In D16421#348361

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis added a comment. In D16421#348363 , @ngraham wrote: > Yeah I understand. I'm not the hugest fan of the orange either, and now that I think about it, semantically it's not really accurate either since that color is for warning or unusual

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Nathaniel Graham
ngraham added a comment. In D16421#348361 , @ndavis wrote: > I agree with you, but I also don't like the look of orange. It's just not a color that I would expect. I would be OK with making `emblem-added` and `emblem-remove` grey like the

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis added a comment. In D16421#348347 , @ngraham wrote: > Wow, these are truly excellent. I think you've done an amazing job! Thanks! > One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red.

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Nathaniel Graham
ngraham added subscribers: bcooksley, ngraham. ngraham added a comment. Wow, these are truly excellent. I think you've done an amazing job! One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red. This color is typically reserved for destructive actions

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Added outlines to 16 and 22 px icons Improved the legibility of 8px icons Added new 8,