D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Stefan Brüns
bruns added a subscriber: FreeBSD. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang, #frameworks, cfeck Cc: #freebsd, bruns, apol, kde-frameworks-devel, michaelh, ngraham

D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Damjan Georgievski
damjang added a comment. is it ok if the waiting on the legacy kwallet4 is made synchronous? wiring all those signals will make my head explode :) wait 5 sec, otherwise give up on the migration? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To:

D16520: proper kwalletd dbus service file for the legacy name

2018-10-30 Thread Stefan Brüns
bruns added a comment. In D16520#350934 , @damjang wrote: > > but before doing this change the migration agent has to be changed. > > Can you expand on this what needs to be changed? I'd be happy to do it if it's in my capability

D16520: proper kwalletd dbus service file for the legacy name

2018-10-30 Thread Damjan Georgievski
damjang added a comment. > but before doing this change the migration agent has to be changed. Can you expand on this what needs to be changed? I'd be happy to do it if it's in my capability REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang,

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Stefan Brüns
bruns added a comment. The old kwalletd(4) from kde-runtime newer installed a service file, as far as I can see. The `org.kde.kwalletd.service` from kwalletd5 only serves one purpose - start the old kwalletd4 as a source for the migration agent. IMHO the much better approach would be

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang added a comment. > So now both kdelibs4 and kf5-kwallet will be installing org.kde.kwalletd.service and the package manager will complain. that was the case even before my patch REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang,

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Aleix Pol Gonzalez
apol added a comment. In D16520#350809 , @damjang wrote: > in what way exactly? > > note that the kwallet package already did install org.kde.kwalletd.service, but also, kdelibs4 apps should be able to use kwalletd5 via the old interface

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang added a comment. In D16520#350807 , @apol wrote: > Won't this break co-installability with kdelibs4? in what way exactly? note that the kwallet package already did install org.kde.kwalletd.service, but also, kdelibs4 apps

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Aleix Pol Gonzalez
apol added a comment. Won't this break co-installability with kdelibs4? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang, #frameworks, cfeck Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, cfeck. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang edited the summary of this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang edited the summary of this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. damjang requested review of this revision. REVISION SUMMARY the org.kde.kwalletd legacy (kde4) name/interface is implemented by kwalletd5. this patch makes a proper dbus