This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R286:3129ba1798fd: [XmlExtractor] Use QXmlStreamReader for
better performance (authored by bruns).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16591
To: bruns, #frameworks, astippich, apol
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
bruns marked 2 inline comments as done.
bruns added inline comments.
INLINE COMMENTS
> apol wrote in xmlextractortest.cpp:70
> Won't this break any use?
Previously, the last element was "foo_bar__", now it is "foo_bar_".
SimpleExtractionResult::append(text) adds a space after the inserted text
apol added a comment.
Patch looks good overall +1
INLINE COMMENTS
> bruns wrote in xmlextractortest.cpp:70
> QDomElement::text() leaves a final trailing whitespace which is not trimmed.
Won't this break any use?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> astippich wrote in xmlextractortest.cpp:70
> why is there a difference?
QDomElement::text() leaves a final trailing whitespace which is not trimmed.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
astippich added inline comments.
INLINE COMMENTS
> xmlextractortest.cpp:70
> QCOMPARE(result.text().leftRef(8), content.leftRef(8));
> -QCOMPARE(result.text().size(), 1 + 8 * count);
> +QCOMPARE(result.text().size(), 8 * count);
>
why is there a difference?
REPOSITORY
R286
bruns added a dependency: D16490: [XmlExtractor] Add unittest for XML extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16591
To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns,
bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
At least in the benchmark, QXmlStreamReader is more than twice as
