D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns added a comment. Fixed ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

bcooksley added a comment. You can rely on shared-mime-info being present on all platforms (Linux, FreeBSD, Windows, Android) yes. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: bcooksley, kde-frameworks-devel,

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns added a comment. In D16593#354311 , @bcooksley wrote: > As noted in the build log on the CI system, kfilemetadata doesn't depend on kcoreaddons so you therefore cannot rely on the kde5.xml file being available: > > [kf5-qt5

D16593: [ExtractorCollection] Use only best matching extractor plugin

bcooksley added a comment. As noted in the build log on the CI system, kfilemetadata doesn't depend on kcoreaddons so you therefore cannot rely on the kde5.xml file being available: [kf5-qt5 SUSEQt5.9] Running shell script + python3 -u ci-tooling/helpers/prepare-dependencies.py

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns added a subscriber: bcooksley. bruns added a comment. In D16593#353801 , @astippich wrote: > This or the commit before causes CI to fail the ExtractorCollectionTest on Qt 5.9, 5.10, and Windows Most likely the new check in D16592

D16593: [ExtractorCollection] Use only best matching extractor plugin

astippich added a comment. This or the commit before causes CI to fail the ExtractorCollectionTest on Qt 5.9, 5.10, and Windows REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo,

D16593: [ExtractorCollection] Use only best matching extractor plugin

This revision was automatically updated to reflect the committed changes. bruns marked 2 inline comments as done. Closed by commit R286:497a69ca846b: [ExtractorCollection] Use only best matching extractor plugin (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16593: [ExtractorCollection] Use only best matching extractor plugin

astippich accepted this revision. astippich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > bruns wrote in extractorcollection.cpp:163 > http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default. I meant the code, not the output :) >

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > astippich wrote in extractorcollection.cpp:163 > nitpick: extra space before "for" http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default. > astippich wrote in extractorcollection.cpp:164 >

D16593: [ExtractorCollection] Use only best matching extractor plugin

astippich added inline comments. INLINE COMMENTS > extractorcollection.cpp:163 > +if (!plugins.isEmpty()) { > +qCDebug(KFILEMETADATA_LOG) << "Using inherited mimetype" << > ancestor << "for" << mimetype; > +return plugins; nitpick: extra space before "for" >

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns created this revision. bruns added reviewers: Frameworks, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY If there is a direct match for a mime type, only the matching