D16617: fix extraction of GPS altitude for exif data

2018-12-01 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:ca8c11351fe7: fix extraction of GPS altitude for exif data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16617?vs=44723=46624

D16617: fix extraction of GPS altitude for exif data

2018-12-01 Thread Alexander Stippich
astippich added a comment. Thanks INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:217 > This is bogus, why am I not allowed to take photos at sea level? Or in > Greenwhich, at the Equator? > > Invalid data should **not** be signaled by 0.0 Yep, I will change that in another diff

D16617: fix extraction of GPS altitude for exif data

2018-11-30 Thread Stefan Brüns
bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > exiv2extractor.cpp:217 > > if (altitude) { > result->add(Property::PhotoGpsAltitude, altitude); This is bogus, why am I not allowed to take photos at sea

D16617: fix extraction of GPS altitude for exif data

2018-11-29 Thread Alexander Stippich
astippich added a comment. gentle ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

2018-11-16 Thread Alexander Stippich
astippich added a dependent revision: D16931: Extract more tags from exif metadata. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16617: fix extraction of GPS altitude for exif data

2018-11-10 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

2018-11-10 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:285 > According to: > https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html > and > http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf > > the absolute altitude value is a rational, like

D16617: fix extraction of GPS altitude for exif data

2018-11-08 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > exiv2extractor.cpp:285 > +if (it != data.end()) { > +alt = it->value().toFloat(); > +it =

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich
astippich added a dependency: D16560: create a separate test file for embedded images test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The previous code was wrong, since the altitude is