This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7c0f6cfa2eae: [server] Text input content hint and
purpose per protocol version (authored by romangg).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16708?vs=44970&id=45033#toc
REPOSITORY
R
romangg marked an inline comment as done.
REPOSITORY
R127 KWayland
BRANCH
textInputEnums
REVISION DETAIL
https://phabricator.kde.org/D16708
To: romangg, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> romangg wrote in textinput_interface.cpp:67
> wlPurpose is also an abbreviation. ;)
>
> And in the header file it is named `purpose`. Makes more sense to me to have
> the
romangg updated this revision to Diff 44970.
romangg added a comment.
- Rename variables, function
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16708?vs=44966&id=44970
BRANCH
textInputEnums
REVISION DETAIL
https://phabricator.kde.org/D16708
AFFECT
romangg added inline comments.
INLINE COMMENTS
> zzag wrote in textinput_interface.cpp:67
> purpose_? or just keep previous name (wlPurpose)?
>
> https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations
wlPurpose is also an abbreviation. ;)
And in the header file it is n
romangg added a dependent revision: D16709: [server] Support text input v0
default content hint.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16708
To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
zzag added inline comments.
INLINE COMMENTS
> textinput_interface.cpp:67
> +const auto hints = p->convertContentHints(hint);
> +const auto purp = p->convertContentPurpose(purpose);
> +if (hints != p->contentHints || purp != p->contentPurpose) {
purpose_? or just keep previous name (w
romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.
REVISION SUMMARY
Convert content hint and purpose according to used text-input protocol
versi
