D16716: skip writing test if mime type is not supported by the extractor

2018-12-06 Thread Alexander Stippich
astippich added a comment. Well, if it is not even signaled via ctest, that's pretty bad, I agree REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16716 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16716: skip writing test if mime type is not supported by the extractor

2018-12-06 Thread Alexander Stippich
astippich updated this revision to Diff 46990. astippich added a comment. - use QFAIL REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16716?vs=44983=46990 BRANCH skip_missing REVISION DETAIL https://phabricator.kde.org/D16716 AFFECTED FILES

D16716: skip writing test if mime type is not supported by the extractor

2018-12-05 Thread Stefan Brüns
bruns added a comment. In D16716#357321 , @astippich wrote: > I think that's my fault when I introduced the extractor for test. Apparently it is using the system libraries, and I'm looking for a solution. > I think a skip is still the right

D16716: skip writing test if mime type is not supported by the extractor

2018-11-10 Thread Alexander Stippich
astippich added a comment. I think that's my fault when I introduced the extractor for test. Apparently it is using the system libraries, and I'm looking for a solution. I think a skip is still the right thing to do here, since we cannot determine if the tags are correctly written.

D16716: skip writing test if mime type is not supported by the extractor

2018-11-06 Thread Stefan Brüns
bruns added a comment. AFAICS the only chance this can happen if the test is using a different library version, e.g. when accidentally using the lib from the system. This would be a test setup error and should be reported with a fail ... REPOSITORY R286 KFileMetaData REVISION DETAIL

D16716: skip writing test if mime type is not supported by the extractor

2018-11-06 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Do not crash if no suitable extractor is found. Skip the