D16735: Implement text_input_unstable_v3

2019-02-08 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > test_text_input.cpp:545-548 > +QFETCH(bool, clientCommits); > +if (clientCommits) { > +textInput->commit(); > +} Personal opinion: tests have to be easy to follow, it's okay if we copy some code. I'd prefer to have a specialized

D16735: Implement text_input_unstable_v3

2018-11-07 Thread Roman Gilg
romangg added a task: T9815: Improve touch/virtual keyboard. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16735 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16735: Implement text_input_unstable_v3

2018-11-07 Thread Roman Gilg
romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Adds support for the text_input_unstable_v3 protocol to our current impleme