D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2019-11-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D16770#569723 , @dfaure wrote: > Hmmpf, indeed. I forgot about the objection I had here :) > > Are you interested in testing my suggested fix, since you seemed to have a testcase for this code? Been some

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2019-11-30 Thread David Faure
dfaure added a comment. Hmmpf, indeed. I forgot about the objection I had here :) Are you interested in testing my suggested fix, since you seemed to have a testcase for this code? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16770 To: kossebau, dfaure Cc:

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2019-11-29 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Solved by D24349 meanwhile in the same way. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16770 To: kossebau, dfaure Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2,

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2018-11-10 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ftp.cpp:1240 > if (!isfile) { > -ftpFolder(remoteEncoding()->directory(url), false);// ignore > errors > +const QString parentDir =

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2018-11-09 Thread Friedrich W. H. Kossebau
kossebau added a subscriber: aacid. kossebau added a comment. @aacid Thanks for providing your ftp server, served its purpose. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16770 To: kossebau, dfaure Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2018-11-09 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "[ftp kio-slave] Fix deletion of directory with non-latin parent path" to "[ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path". kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY