apol added a comment.
Tests fixed, sorry about that.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D16867
To: apol, #plasma, #frameworks, ngraham
Cc: dfaure, ngraham, kde-frameworks-devel, michaelh, bruns
dfaure added a comment.
More casualties: the kpackage unittests...
https://build.kde.org/job/Frameworks/view/Everything/job/kpackage/job/kf5-qt5%20SUSEQt5.10/90/testReport/junit/(root)/TestSuite/testjsonmetadatapackage_appstream/
and 5 others
rikmills added a comment.
And we have a casualty from this ;)
Marble 18.12 branch:
> CMake Warning at
/usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:68 (message):
>couldn't generate metainfo for org.kde.plasma.worldmap: Package type
>
apol closed this revision.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D16867
To: apol, #plasma, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Thanks, this looks like a good fix.
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16867
To: apol, #plasma, #frameworks, ngraham
Cc: ngraham,
apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
They end up being broken appstream files and it fails on the users' faces.
Have
