D16913: Add the possibility to give focus to the KPluginSelector search field

2019-03-26 Thread Thomas Surrel
thsurrel added a comment. No worries, the other patch is better actually. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-03-26 Thread Nathaniel Graham
ngraham added a comment. Oh gosh I completely forgot about this, sorry. :( REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-03-26 Thread Thomas Surrel
thsurrel abandoned this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-02-25 Thread Nathaniel Graham
ngraham added a reviewer: Plasma. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-02-25 Thread Thomas Surrel
thsurrel updated this revision to Diff 52507. thsurrel added a comment. Rebase REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16913?vs=50295=52507 BRANCH arc_focussearch (branched from master) REVISION DETAIL https://phabricator.kde.org/D16913

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-01-25 Thread Thomas Surrel
thsurrel updated this revision to Diff 50295. thsurrel added a comment. Remove the timer REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16913?vs=45550=50295 BRANCH arc_focussearch (branched from master) REVISION DETAIL

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-01-08 Thread Thomas Surrel
thsurrel added a comment. I'm on strike until my device notifier patches are reviewed ;) More seriously, I did not have the time to look into gammaray. I will as soon as I can, but don't hesitate to tell me if you want to take over this patch. REPOSITORY R295 KCMUtils REVISION DETAIL

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-01-01 Thread Nathaniel Graham
ngraham added a comment. Any update on this? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-12-07 Thread Thomas Surrel
thsurrel added a comment. Thanks for the tip, I will try to use gammaray. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-12-07 Thread David Edmundson
davidedmundson added a comment. > Correct me if this is wrong. It shouldn't be needed, no. This is a workaround for something, potentially another widget pulling focus on startup. gammaray can be a fantastic tool in diagnosing this sort of thing. REPOSITORY R295 KCMUtils

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-19 Thread Nathaniel Graham
ngraham added subscribers: broulik, cfeck. ngraham added a comment. Sounds like you know more than I do at this point. :) Let's see if this approach makes sense to @cfeck or @broulik. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-19 Thread Thomas Surrel
thsurrel added a comment. Simply calling setFocus() was not working (I used this in D16914 ). My understanding is that the widget containing this has to be completely built before trying to set the focus, adding the timer ensures that. Correct me if this

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-17 Thread Nathaniel Graham
ngraham added a comment. Why does this need a timer? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-15 Thread Thomas Surrel
thsurrel added a dependent revision: D16914: [Runners KCM] Focus the search field by default. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-15 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R295 KCMUtils BRANCH arc_focussearch (branched from master) REVISION DETAIL