D16930: Android: improve clang support
This revision was automatically updated to reflect the committed changes. Closed by commit R240:06061b0e3ce4: Android: improve clang support (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16930?vs=45606&id=45816 REVISION DETAIL https://phabricator.kde.org/D16930 AFFECTED FILES toolchain/Android.cmake toolchain/ECMAndroidDeployQt.cmake toolchain/deployment-file.json.in toolchain/specifydependencies.cmake To: apol, #build_system, #android, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D16930: Android: improve clang support
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks ok to me, less stuff to set manually is always good. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D16930 To: apol, #build_system, #android, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D16930: Android: improve clang support
apol created this revision. apol added reviewers: Build System, Android, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Infer the toolchain we are using through cmake's detection of ranlib instead of asking the user to fill it. It's only used in androiddeployqt and cmake expects it to be version "clang" for clang builds while androiddeployqt expects it to be "4.9". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D16930 AFFECTED FILES toolchain/Android.cmake toolchain/ECMAndroidDeployQt.cmake toolchain/deployment-file.json.in toolchain/specifydependencies.cmake To: apol, #build_system, #android, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
