D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella added a comment. In D16951#363898 , @ndavis wrote: > So now I have 2 commits and one of them is already on master, but they're both called "Add mouse button icons" and use the same description. Should I update this diff to describe

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. So now I have 2 commits and one of them is already on master, but they're both called "Add mouse button icons" and use the same description. Should I update this diff to describe only the latest commit or make it apply to both? REPOSITORY R266 Breeze Icons BRANCH

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis updated this revision to Diff 45981. ndavis marked an inline comment as done. ndavis added a comment. Rebase onto master again REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45980=45981 BRANCH arcpatch-D16951 REVISION DETAIL

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951_1 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham,

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. Ok, I see what the issue was. The conflicts are literally stored *in* the file that has the conflict as text, so `dialog-input-devices.svg` was turned into a diff of the old and new versions. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis updated this revision to Diff 45980. ndavis added a comment. Fix conflicts REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45979=45980 BRANCH arcpatch-D16951_1 REVISION DETAIL https://phabricator.kde.org/D16951 AFFECTED FILES

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella added a comment. This assumes the files that you uploaded before the merge are all correct. - Save the correct icons somewhere. - Checkout the old diff: arc patch --diff 45755 - Begin rebase: git rebase master - Override the files with conflicts with the files you saved

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. In D16951#363879 , @nicolasfella wrote: > In D16951#363878 , @ndavis wrote: > > > Save what or how? Doesn't `arc diff --update D16951` save things? I know I added the right

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella added a comment. In D16951#363878 , @ndavis wrote: > Save what or how? Doesn't `arc diff --update D16951` save things? I know I added the right files and there were only 2 conflicts (`icons/actions/16/dialog-input-devices.svg` and

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. In D16951#363876 , @nicolasfella wrote: > In D16951#363875 , @ndavis wrote: > > > I thought I did this already. I rebased onto master, then added the version of the file I

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella added a comment. I any case, try again and check the files for merge conflict markers REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello,

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella added a comment. In D16951#363875 , @ndavis wrote: > I thought I did this already. I rebased onto master, then added the version of the file I wanted, then continued the rebase, then updated the diff. Is there something I missed?

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. I thought I did this already. I rebased onto master, then added the version of the file I wanted, then continued the rebase, then updated the diff. Is there something I missed? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To:

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella reopened this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella,

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello,

D16951: Add mouse button icons

2018-11-21 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > dialog-input-devices.svg:3 >

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:6976172920e2: Add mouse button icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45978=45979 REVISION DETAIL

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. In D16951#363861 , @nicolasfella wrote: > Looks great! Ah thanks! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham,

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis updated this revision to Diff 45978. ndavis added a comment. Rebase onto master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45755=45978 BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 AFFECTED FILES

D16951: Add mouse button icons

2018-11-21 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. Looks great! REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: trickyricky26, abetts,

D16951: Add mouse button icons

2018-11-21 Thread Noah Davis
ndavis added a comment. It's been 3 days and no response. It has already been approved by another reviewer, so I'm going to land this now. REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg,

D16951: Add mouse button icons

2018-11-21 Thread Albert Vaca Cintora
albertvaka added a reviewer: KDE Connect. REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella,

D16951: Add mouse button icons

2018-11-18 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a reviewer: nicolasfella. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me now! Let's make sure @nicolasfella is happy too, since he's going to be the inaugural user. :) REPOSITORY R266 Breeze Icons

D16951: Add mouse button icons

2018-11-18 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

2018-11-18 Thread Noah Davis
ndavis updated this revision to Diff 45755. ndavis added a comment. Detach MMB, increase highlight length, make colors match new HIG, turn MMB click highligh into outline REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45703=45755 BRANCH

D16951: Add mouse button icons

2018-11-18 Thread Nicolas Fella
nicolasfella added a comment. Looks good! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

2018-11-18 Thread TrickyRicky
trickyricky26 added a comment. I think it's not quite clear enough on it's own, however together with the other icons it will be clear REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello,

D16951: Add mouse button icons

2018-11-18 Thread Noah Davis
ndavis added a comment. F6430803: Screenshot_20181118_123558.png Is this too small or not legible enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham,

D16951: Add mouse button icons

2018-11-18 Thread TrickyRicky
trickyricky26 added a comment. I would suggest making the mouse wheel itself turn blue as highlighting REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel,

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis added a comment. In D16951#361317 , @ngraham wrote: > What about making the MMB turn white when it has the blue highlight? white MMB F642: Screenshot_20181118_005525.png white MMB

D16951: Add mouse button icons

2018-11-17 Thread Nathaniel Graham
ngraham added a comment. What about making the MMB turn white when it has the blue highlight? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis added a comment. In D16951#361294 , @ngraham wrote: > Much better shape! > > What do you think about making the mouse wheel detached from the top of the mouse so it looks more like a wheel and less like a notch? Then also you might

D16951: Add mouse button icons

2018-11-17 Thread Nathaniel Graham
ngraham added a comment. Much better shape! What do you think about making the mouse wheel detached from the top of the mouse so it looks more like a wheel and less like a notch? Then also you might not need to omit it from `input-mouse-click-middle`' REPOSITORY R266 Breeze Icons

D16951: Add mouse button icons

2018-11-17 Thread Andres Betts
abetts added a comment. Looks good to me +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis planned changes to this revision. ndavis added a comment. Alright, that's 2 people in favor of a curved mouse. After all, we're not using Apple Macintoshes from the 80s. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: ngraham,

D16951: Add mouse button icons

2018-11-17 Thread Nathaniel Graham
ngraham added a comment. +1 for more curves. That rectangle doesn't particular scream "I'm a mouse!" to me. `dialog-input-devices` itself is pretty lousy, honestly. It would also use a bit of sprucing up rather than copying its style. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis added a comment. In D16951#360965 , @rizzitello wrote: > I think the Mouse itself needs a bit more curve with less box. I kind of agree. I was just copying the existing `dialog-input-devices` icon, but I suppose I could change

D16951: Add mouse button icons

2018-11-17 Thread Chris Rizzitello
rizzitello added a comment. I think the Mouse itself needs a bit more curve with less box. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis added a subscriber: nicolasfella. ndavis added a comment. @nicolasfella Will these work for you? Let me know if you need thumb buttons as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: nicolasfella,

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

2018-11-17 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add left, middle and right click icons for KDE Connect FEATURE: 399295 FIXED-IN: