D16981: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed

2018-12-16 Thread Nathaniel Graham 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:33442c012eb2: [kfilewidget] Return editable URL navigator 
to breadcrumb mode if it has focus… (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16981?vs=46932&id=47698

REVISION DETAIL
  https://phabricator.kde.org/D16981

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16981: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed

2018-12-16 Thread Nathaniel Graham 
ngraham added a comment.


  Landing this too since its Dolphin companion (D16980 
) has been accepted, and the code change is 
virtually identical.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16981

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16981: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed

2018-12-05 Thread Nathaniel Graham 
ngraham updated this revision to Diff 46932.
ngraham added a comment.


  Add a comment for clarity

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16981?vs=46931&id=46932

BRANCH
  arcpatch-D16981

REVISION DETAIL
  https://phabricator.kde.org/D16981

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16981: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed

2018-12-05 Thread Nathaniel Graham 
ngraham retitled this revision from "[kfilewidget] Ctrl+L returns editable URL 
navigator to breadcrumb mode only when it has focus" to "[kfilewidget] Return 
editable URL navigator to breadcrumb mode if it has focus and everything is 
selected and when Ctrl+L is pressed".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16981

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns