D17017: Fix assert when cleaning up symlinks in PreviewJob
This revision was automatically updated to reflect the committed changes. Closed by commit R241:7ce34436a038: Fix assert when cleaning up symlinks in PreviewJob (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17017?vs=45809&id=46264 REVISION DETAIL https://phabricator.kde.org/D17017 AFFECTED FILES src/widgets/previewjob.cpp To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17017: Fix assert when cleaning up symlinks in PreviewJob
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17017 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17017: Fix assert when cleaning up symlinks in PreviewJob
elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17017 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17017: Fix assert when cleaning up symlinks in PreviewJob
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY When previewing files in a KIOslave KIO will copy the file out to a temporary directory and then run the preview on that. If I have a symlink in a slave (for example trashing a symlink) the preview job will copy the symlink to the temporary directory. QFileInfo follows symlinks for methods like isDir(), in this case we shouldn't assert as QFile::remove will correctly just cleanup the symlink. TEST PLAN Created a symlink to a directory Trashed it Opened trash:// in dolphin with previews enabled Used to hit an assert Now don't REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17017 AFFECTED FILES src/widgets/previewjob.cpp To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
