D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

This revision was automatically updated to reflect the committed changes. Closed by commit R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button (authored by loh.tar, committed by ngraham). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar added a comment. No, but that's fine. One thing less where I can make mistakes :-) Should your next question be regarding author ship, take a look at edbf2e36c805 Thanks. REPOSITORY R246 Sonnet

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

ngraham added a comment. Do you have commit access? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, I see now. A smaller dump. :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar added a comment. Um, no(?) In that case I would have named this patch "Add stretch to ensure Dump button is expanding" Sorry, next time I try to describe the pics more precise. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

ngraham added a comment. So this patch makes the Dump button much wider? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 AFFECTED FILES examples/dictionarycombobox.cpp To: loh.tar Cc: kde-frameworks-devel, michaelh, ngraham,