D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-12-09 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R246:a38e1c04a035: Dialog: Use DictionaryComboBox instead of plain QComboBox (authored by loh.tar, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-12-09 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Like the change in KTextEditor, I think this should go in. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17056 To: loh.tar, #frameworks, cullmann Cc:

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17056 To: loh.tar, #frameworks Cc: mludwig, kde-frameworks-devel, michaelh, ngraham, bruns

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-11-20 Thread loh tar
loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REVISION SUMMARY This patch alone is reasonable but become really important with the aim of D17030 REPOSITORY R246 Sonnet REVISION DETAIL