D17079: Provide a qqc2/kirigami-based about page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:673981634266: Provide a qqc2/kirigami-based about page (authored by apol). REPOSITORY R134 Discover Software Store

D17079: Provide a qqc2/kirigami-based about page

vkrause added a comment. In D17079#364308 , @mart wrote: > In D17079#364263 , @apol wrote: > > > In D17079#364163 , @ltoscano wrote: > > > > > kcoreaddo

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#364263 , @apol wrote: > In D17079#364163 , @ltoscano wrote: > > > In D17079#364157 , @mart wrote: > > > > > I think this

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#364163 , @ltoscano wrote: > In D17079#364157 , @mart wrote: > > > I think this ui should really go into KCoreAddons itself. Would it be accepted there? > > > kco

D17079: Provide a qqc2/kirigami-based about page

ltoscano added a comment. In D17079#364157 , @mart wrote: > I think this ui should really go into KCoreAddons itself. Would it be accepted there? kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, kirigami-addons (

D17079: Provide a qqc2/kirigami-based about page

mart added inline comments. INLINE COMMENTS > DiscoverWindow.qml:76 > } > +TopLevelPageData { > +id: aboutAction can you try how does it look for this page to be pushed as a layer instead of the main PageRow? would be like applicationWindow().pageStack.layers.push(thecomponento

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. I think this ui should really go into KCoreAddons itself. Would it be accepted there? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragree

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#363975 , @ngraham wrote: > Cool! > > For this design, I'd like to get rid of the tabs and put everything in a scrollview. We generally have enough space that a tabbed view is overkill. +1 REPOSITORY

D17079: Provide a qqc2/kirigami-based about page

leinir added a comment. Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact th

D17079: Provide a qqc2/kirigami-based about page

ngraham added a comment. Cool! For this design, I'd like to get rid of the tabs and put everything in a scrollview. We generally have enough space that a tabbed view is overkill. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #p

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#363906 , @ltoscano wrote: > That's a great idea! Would it be possible: > > - to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some

D17079: Provide a qqc2/kirigami-based about page

ltoscano added a comment. That's a great idea! Would it be possible: - to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some groundwork is needed here) - to move this about page to some common kirigami-addo

D17079: Provide a qqc2/kirigami-based about page

apol edited the summary of this revision. apol added a dependency: D17080: Make it possible to fallback to a different icon. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, l

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. WRT the gravatar bit, I'm not married to it, it's just a way to have this moving forward. I'll add some screenshots so you get an idea: F6435584: discover-about1.png F6435585: discover-about2.png

D17079: Provide a qqc2/kirigami-based about page

apol updated this revision to Diff 45968. apol added a comment. Don't show the gravatar logo when not there REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17079?vs=45965&id=45968 BRANCH master REVISION DETAIL https://phabricator.kde.or

D17079: Provide a qqc2/kirigami-based about page

apol edited the summary of this revision. apol added a dependency: D17078: Make it possible to use KAboutData/License/Person from QML. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: plasma-devel, ragreen, Pitel,

D17079: Provide a qqc2/kirigami-based about page

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of using the one in xmlgui, create one that integrates properly in Kirigami/Discover.