D17088: [thumbnailer appimage] Fix building with libappimage not in system path

2018-11-22 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:6c2ebbb5b853: [thumbnailer appimage] Fix building with libappimage not in system path (authored by kossebau).

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

2018-11-22 Thread TheAssassin
TheAssassin added a comment. There will be packages for libappimage (hopefully) soon, which provide a `.pc` file. This provides an alternative to using these generated CMake config files, which can be used through CMake's pkg-config module (`find_package(PkgConfig)`). REPOSITORY R320 KIO

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

2018-11-22 Thread Kai Uwe Broulik
broulik added a comment. Don't know much cmake but still builds fine here with this change, so +1 from me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D17088 To: kossebau, broulik, TheAssassin, azubieta Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss,

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

2018-11-21 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: broulik, TheAssassin, azubieta. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The current CMake Config file of