This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R293:149c8b2379df: Do not add
Type::Document/Presentation/Spreadsheet twice for MS Office docs (authored by
bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> lbeltrame wrote in basicindexingjob.cpp:153
> Remove instead of committing commented out code?
I prefer not to remove it, at least not completely. I think it is useful to
have the mimetypes listed
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM; just a minor change needed.
INLINE COMMENTS
> basicindexingjob.cpp:153
> +//{"application/vnd.ms-excel", Type::Document},
> +//{"application/vnd.ms-excel",
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
The mimetype is matched with "powerpoint" and "excel"
