D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:edbf2e36c805: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think neither the dialog/spellcheck bar nor the context menu things got any love in the close past. If you have time to improve this, any patch is welcome! I will apply this

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-22 Thread loh tar
loh.tar added a comment. It would be nice someone could explain, or point me where to read, why there is no (more) direct use of Sonnet stuff in KTextEditor/Kate. 1. KTextEditor::SpellCheckBar looks (almost) the same as Sonnet::Dialog but has differently ingredients. I had expect, after

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-22 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: cullmann. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch alone is