D17167: Provide a method of assigning custom default icons for non-XDG dirs

2019-03-19 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. The " 'Too much magic' trap" makes sense to me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2019-03-19 Thread David Faure
dfaure added a comment. IMHO this falls into the "too much magic" trap. If a user creates ~/Games it will have a special icon, but if he creates ~/Videogames, ~/mygames, ~/Steam, or choose a different translation than the translators picked, it won't trigger that magic -- with no indication

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2019-03-18 Thread Nathaniel Graham
ngraham added a comment. Ping? Any opinions regarding what I wrote in https://phabricator.kde.org/D17167#383242? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-12-28 Thread Nathaniel Graham
ngraham added a comment. In D17167#371906 , @cfeck wrote: > But why hardcode the list in the source, instead of reading it from a file/resource that the user could expand? I don't see the benefit of putting the data into a configuration

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-12-05 Thread Christoph Feck
cfeck added a comment. But why hardcode the list in the source, instead of reading it from a file/resource that the user could expand? Ideally, the "New Folder" dialog would have a button to pick an icon, and a checkbox "Remember icon for this folder name", automatically appending/replacing

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-12-05 Thread Nathaniel Graham
ngraham added a comment. In D17167#368727 , @dfaure wrote: > This feels *very* special cased. Where does this automagic ends? Any why only in $HOME? We'll keep adding entries here forever... Why don't people use a .directory file for this? >

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-30 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This feels *very* special cased. Where does this automagic ends? Any why only in $HOME? We'll keep adding entries here forever... Why don't people use a .directory file for this?

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-28 Thread Kai Uwe Broulik
broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 46234. ngraham added a comment. Match existing brace style for inline initializer REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17167?vs=46233=46234 BRANCH custom-icons-for-non-xdg-dirs (branched from master) REVISION

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 46233. ngraham added a comment. Correct typo in the comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17167?vs=46232=46233 BRANCH custom-icons-for-non-xdg-dirs (branched from master) REVISION DETAIL

D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-25 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, cfeck, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adds a new folder-to-icon map that makes it possible to