D17190: Add level api from Kirigami.Heading

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> ktitlewidget.cpp:132
>  titleFrame->setBackgroundRole(QPalette::Base);
> +titleFrame->setContentsMargins(0, 0, 0, 0);
>  

Setting 0 margins effectively disables the frame; the Breeze setting to keep 
frames around page titles is no longer respected.

If this is intended, the frame shouldn't set a background role (and the code 
would have to be checked regarding correct foreground colors).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg, ngraham
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d3964629cbff: Add level api from Kirigami.Heading 
(authored by mart).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17190?vs=46322=46463

REVISION DETAIL
  https://phabricator.kde.org/D17190

AFFECTED FILES
  src/ktitlewidget.cpp
  src/ktitlewidget.h

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/heading

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Fabian Riethmayer]

fabianr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Marco Martin]

mart added a comment.


  In D17190#366854 , @ngraham wrote:
  
  > In those screenshots, "< Fonts" is basically just a named back button. 
Should it really have the same size and visual weight as the active KCMs' title?
  
  
  I think so, it's the title of what the underlying listview is about, which is 
"the other kcm you can open now" which should have the same weight as what the 
current kcm is
  
  that's for D17192  btw

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Nathaniel Graham]

ngraham added a comment.


  In D17190#366840 , @mart wrote:
  
  > F6443889: image.png 
  >
  > with a QWidget KCM
  >  F6443893: image.png 
  
  
  In those screenshots, "< Fonts" is basically just a named back button. Should 
it really have the same size and visual weight as the active KCMs' title?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Marco Martin]

mart added a comment.


  F6443889: image.png 
  
  with a QWidget KCM
  F6443893: image.png 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  add a "level" api that has the same meaning as in the Kirigami Heading 
component,
  This makes easier for QWidget apps to follow the typographi HIG at
  https://www.my-scratch.de/HIG/style/typography.html
  QWidget and QML apps will look more similar and config dialogs
  the same.
  together other diffs introduces more consistency within SystemSettings
  between QWidget and QML based kcms

TEST PLAN
  ran a lot of config dialogs

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/heading

REVISION DETAIL
  https://phabricator.kde.org/D17190

AFFECTED FILES
  src/ktitlewidget.cpp
  src/ktitlewidget.h

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns