D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread Daniel Levin
dlevin added a comment.


  This language does not have folding test. I did not provide validation for it 
before. Should I do that?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread Christoph Cullmann
cullmann added a comment.


  Upsa, you are right.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread David Faure
dfaure added a comment.


  It seems this commit is the reason for the unittest failure below?
  
  
https://build.kde.org/job/Frameworks/view/Everything/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/258/testReport/junit/(root)/TestSuite/folding_test/
  
--- "/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 
SUSEQt5.10/autotests/folding/brightscript.brs.fold" 2018-11-28 
07:43:45.708060965 +
+++ "/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 
SUSEQt5.10/build/autotests/folding.out/brightscript.brs.fold"   2018-11-28 
07:45:08.202953752 +
@@ -96,4 +96,10 @@
 
 b.foo("string",1,{a:b},1.5,[1,2,3])
 a = b.foo("string",1,{a:b},1.5,[1,2,3])
+
+unnamed_function = function ( a as Integer ) as Float
+end function
+
+unnamed_sub = sub ( a as Integer ) as Void
+end sub
 endFunction
FAIL!  : FoldingTest::testFolding(brightscript.brs) Compared values are not 
the same
   Actual   (proc.exitCode()): 1
   Expected (0)  : 0

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c45565159924: BrightScript: Allow sub to be unnamed 
(authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17204?vs=46371=46375

REVISION DETAIL
  https://phabricator.kde.org/D17204

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sure :/ I missed to change author last time, I normally am just 
patching/landing via arc, but that doesn't always contain that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin added a comment.


  Thanks for the review. Btw, is there any chance to preserve my name/email in 
the final commit?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin updated this revision to Diff 46371.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17204?vs=46369=46371

REVISION DETAIL
  https://phabricator.kde.org/D17204

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Christoph Cullmann
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Looks reasonable, but you need to increase the version.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Subs and functions could be unnamed in closures.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann