jgrulich closed this revision.
jgrulich added a comment.
Closed by
https://cgit.kde.org/networkmanager-qt.git/commit/?id=ee74458db6593ed05b89c257de5789d02a0fb64d.
REVISION DETAIL
https://phabricator.kde.org/D17210
To: pranavgade, jgrulich
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh,
jgrulich accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D17210
To: pranavgade, jgrulich
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns
pranavgade updated this revision to Diff 46488.
pranavgade marked 2 inline comments as done.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17210?vs=46469&id=46488
REVISION DETAIL
https://phabricator.kde.org/D17210
AFFECTED FILES
autotests/settings/CMakeLists.txt
autotests/settin
jgrulich added inline comments.
INLINE COMMENTS
> proxysetting.cpp:37
> +: name(NM_SETTING_PROXY_SETTING_NAME)
> +, browserOnly(true)
> +, method(ProxySetting::None)
Default value is false.
> usersetting.cpp:94
> +}
> +
> +
One empty line is enough.
REPOSITORY
R282 NetworkMa
pranavgade set the repository for this revision to R282 NetworkManagerQt.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D17210
To: pranavgade, jgrulich
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns
cfeck added a comment.
Could you please set the Repository field?
REVISION DETAIL
https://phabricator.kde.org/D17210
To: pranavgade, jgrulich
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns
pranavgade marked 3 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D17210
To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
pranavgade marked 3 inline comments as done.
pranavgade added inline comments.
INLINE COMMENTS
> jgrulich wrote in proxysetting.cpp:25
> It looks that the proxy setting has been introduced in NetworkManager 1.6.
> This means that for all property defines, you have to add ifdef the same way
> yo
pranavgade updated this revision to Diff 46469.
pranavgade added a comment.
made some changes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17210?vs=46467&id=46469
REVISION DETAIL
https://phabricator.kde.org/D17210
AFFECTED FILES
autotests/settings/CMakeLists.txt
autotests/s
jgrulich added inline comments.
INLINE COMMENTS
> iptunnelsetting.cpp:35
> , encapsulationLimit(0)
> -, flags(IpTunnelSetting::Unknown)
> +, flags(IpTunnelSetting::None)
> , flowLabel(0)
This is an unrelated change, submit it in a different review, but thanks for
spotting this
pranavgade updated this revision to Diff 46467.
pranavgade marked 6 inline comments as done.
pranavgade added a comment.
Updated code as required,
fixed a minor error in iptunnelsettings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17210?vs=46444&id=46467
REVISION DETAIL
http
jgrulich added inline comments.
INLINE COMMENTS
> proxysetting.cpp:25
> +#include
> +
> +NetworkManager::ProxySettingPrivate::ProxySettingPrivate()
It looks that the proxy setting has been introduced in NetworkManager 1.6. This
means that for all property defines, you have to add ifdef the sam
pranavgade updated this revision to Diff 46444.
pranavgade added a comment.
Updated diff from prev commit->changes to latest commit->changes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17210?vs=46392&id=46444
REVISION DETAIL
https://phabricator.kde.org/D17210
AFFECTED FILES
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.
REVISION SUMMARY
Added proxy and user settings according to:
https://developer.gnome.org/N
14 matches
Mail list logo
