D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 updated this revision to Diff 46504.
trickyricky26 added a comment.


  - Apply new off and muted styles; add 22px audio-status icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17220?vs=46419=46504

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-on.svg
  icons-dark/status/22/audio-ready.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/input-touchpad-off.svg
  icons-dark/status/22/mic-off.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/audio-off.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-on.svg
  icons/status/22/audio-ready.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/input-touchpad-off.svg
  icons/status/22/mic-off.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 added a comment.


  `22px` is okay imo; however I've enlarged it quite a bit for `16px`:
  F6446668: audio-volume-muted-alt-16.svg.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  In D17220#368147 , @trickyricky26 
wrote:
  
  > F6446578: audio-volume-muted-alt-22.svg.png 

  
  
  This is really nice, at least at large size. How does it fare in the UI when 
it's tiny? Is the red part still distinguishable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Andres Betts]

abetts added a comment.


  In D17220#368147 , @trickyricky26 
wrote:
  
  > I think the distinction is useful. The off icons would then look like this:
  >  F6446567: microphone-sensitivity-high-22.svg.png 

  >
  > F6446566: audio-volume-high-22.svg.png 

  >  Should this style then also be applied to other "off" status icons like 
touchpad and camera?
  >
  > Also, I've experimented with a circle with one line through it, as that 
represents muted better than an X which looks too much like an error:
  >  F6446578: audio-volume-muted-alt-22.svg.png 

  
  
  These look really good. My only warning to the team is that we don't add too 
many elements to the icon that will make it expand in area. We should strive to 
keeping size constraints so that we don't introduce too many elements into the 
icon that will make it be confusing visually.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 added a comment.


  I think the distinction is useful. The off icons would then look like this:
  F6446567: microphone-sensitivity-high-22.svg.png 

  
  F6446566: audio-volume-high-22.svg.png 
  
  Also, I've experimented with a circle with one line through it, as that 
represents muted better than an X which looks too much like an error:
  F6446578: audio-volume-muted-alt-22.svg.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Noah Davis]

ndavis added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  You're the hero KDE needs.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Noah Davis]

ndavis added a comment.


  In D17220#367858 , @ngraham wrote:
  
  > In D17220#367849 , @ndavis wrote:
  >
  > > Here's what the Breeze Plasma desktop theme uses for the 
`network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png 

  >
  >
  > That fact that slightly different versions those icons live in two places 
(Breeze plasma icon theme & general Breeze icon theme) is... not ideal. :/
  
  
  Yes, I'm working on bringing the Breeze desktop theme icons into 
breeze-icons, but it will take a while.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  In D17220#367849 , @ndavis wrote:
  
  > Here's what the Breeze Plasma desktop theme uses for the 
`network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png 

  
  
  That fact that slightly different versions those icons live in two places 
(Breeze plasma icon theme & general Breeze icon theme) is... not ideal. :/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Noah Davis]

ndavis added a comment.


  Could a distinction between "off" and "muted" be useful? If that is true, 
then we should keep the red horizontal dash for muted and use a red slash 
through the whole icon for off/disabled. In general, I think a red X should 
mean "error", but we're not consistent about that yet. I also think the sound 
waves should be reversed on the microphone icon since microphones don't 
normally make noise.
  
  Here's what the Breeze Plasma desktop theme uses for the 
`network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png 

  
  The icon above it with the red X is `network-wireless-disconnected`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  the `status/22/audio-volume-muted` icons are still being replaced with 
symlinks, so I still can't apply the patch. :(

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 updated this revision to Diff 46419.
trickyricky26 added a comment.


  - Change symlinks

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17220?vs=46418=46419

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/mic-off.svg
  icons/status/16/audio-off.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/mic-off.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  If you reverse that such that no existing files are replaced with symlinks, 
it will certainly make it easier to review this patch. If necessary, after that 
I can do the symlink switcheroo in a separate commit to keep life sane.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 added a comment.


  I changed the symlinks to point from the off icons to the muted icons; but I 
could reverse that.
  
  Before, the symlinks pointed from the muted icons to the off icons, except 
for `audio-{on;off;ready}` icons, which don't exist at `22px` at all. Perhaps I 
should add `audio-on` and `audio-ready` in `22px` as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  Oh jeez, this patch replaces some icons with symlinks which makes Phabricator 
unable to apply the patch. :/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/mic-off.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/audio-off.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/mic-off.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns