D17237: KTextEditor::ViewPrivate: S

2018-11-30 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ad4ec47eb73a: KTextEditor::ViewPrivate: SR (authored 
by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17237?vs=46484=46534

REVISION DETAIL
  https://phabricator.kde.org/D17237

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17237: KTextEditor::ViewPrivate: S

2018-11-30 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks ok as is, thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17237

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17237: KTextEditor::ViewPrivate: S

2018-11-29 Thread loh tar 
loh.tar added a comment.


  I can split it if you like in two diff
  
  - 'm_doc->' => 'doc()->' ~100 hits, perhaps not the best idea? A search for 
doc() has 24 hits (without this patch)
  - 'm_viewInternal->m_cursor' => 'cursorPosition()' ~10 hits
  
  Next would be look for inline candidates, look for S in KateViewInternal

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17237

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17237: KTextEditor::ViewPrivate: S

2018-11-29 Thread loh tar 
loh.tar created this revision.
loh.tar added reviewers: cullmann, KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - 'm_doc->' => 'doc()->'
  - 'm_viewInternal->m_cursor' => 'cursorPosition()'

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17237

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann