This revision was automatically updated to reflect the committed changes.
Closed by commit R39:87bcf0f51270: KateViewInternal: SR (authored by
loh.tar, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17257?vs=46561=46909
REVISION
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
No, I was just busy ;=)
Diff looks ok, will apply.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17257
To: loh.tar, #ktexteditor, cullmann
Cc:
loh.tar added a comment.
@cullmann Did you notice this? The other patches did you apply very quick, so
I hope I didn't unsettle you with my comments.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17257
To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel,
loh.tar added a comment.
Only 'm_view->' => 'view()' has plenty of hits, the others only a few.
Please do a grep for m_startPos. To replace these few would require a
changed or added function.
Last note: I hope you test all these changes thoroughly. At the last
mentioned
loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
- 'm_view->' => 'view()'
- 'm_startPos.line()' =>
