D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Jan Grulich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:25118c3e80ce: Fixed a bug(error?) in ipv4 & ipv6 
settings (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17258?vs=46563&id=46566

REVISION DETAIL
  https://phabricator.kde.org/D17258

AFFECTED FILES
  src/settings/ipv4setting.cpp
  src/settings/ipv6setting.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Jan Grulich 
jgrulich added a comment.


  Thanks for spotting this. I wonder how it's possible this passed the test, I 
guess comparing it the way we do, it doesn't compare it properly. I'll check 
the tests further.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Pranav Gade 
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Fixed a couple of misplaced lines of code

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

AFFECTED FILES
  src/settings/ipv4setting.cpp
  src/settings/ipv6setting.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns