D17309: Add flashlight action icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:852abccbb09a: Add flashlight action icons (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17309?vs=46904&id=4

D17309: Add flashlight action icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH flashlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg, ngraham, ndavis Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I like it! REPOSITORY R266 Breeze Icons BRANCH flashlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg, ngraham Cc: abet

D17309: Add flashlight action icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

trickyricky26 updated this revision to Diff 46904. trickyricky26 added a comment. - Switch to horizontal orientation for clarity REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17309?vs=46705&id=46904 BRANCH flashlight-icons (branched from master) R

D17309: Add flashlight action icons

trickyricky26 added a comment. There we go: F6457800: Changes.png I think this looks quite nice and a bit clearer with the 16px icons as well. Will update the patch soon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.or

D17309: Add flashlight action icons

trickyricky26 added a comment. Ok, will do when I have some time :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

ngraham added a comment. I also like the horizontal one better. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

ndavis added a comment. In D17309#370774 , @trickyricky26 wrote: > Do you think this style is better (16px versions shown): > F6453093: Alternate Style.png I think so. It's more obvious that it's

D17309: Add flashlight action icons

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

trickyricky26 added a comment. Do you think this style is better (16px versions shown): F6453093: Alternate Style.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: ndavis, ngraham, kde-

D17309: Add flashlight action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

ndavis added a comment. Reminds me of these: http://store.t-studious.com/wp-content/uploads/2016/12/Maglite-2D-LED-Torch-.jpg I like the 32px version, but it kind of just looks like a tube with the 16px `flashlight-off` icon. What if you turned the head of the flashlight to the right? T

D17309: Add flashlight action icons

trickyricky26 added a comment. The main issue is that the added lines are too much complexity for 16px icons. They are probably possible for 22px and up, at the expense of making the flashlight look a bit short. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D1

D17309: Add flashlight action icons

ngraham added a comment. Looks pretty nice to me! I find myself wanting some little lines coming out of the top of the "on" version though. I guess that means we would need to add them as well for the "off" versions too though, and maybe that would look weird? REPOSITORY R266 Breeze Icons

D17309: Add flashlight action icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D17309: Add flashlight action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH flashlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org