D17331: Extend PositionCodec unit tests, better code coverage

2018-12-20 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b5fd732b171e: Extend PositionCodec unit tests, better 
code coverage (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17331?vs=46790=47899

REVISION DETAIL
  https://phabricator.kde.org/D17331

AFFECTED FILES
  autotests/benchmarks/positioncodecbenchmark.cpp
  autotests/unit/codecs/positioncodectest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17331: Extend PositionCodec unit tests, better code coverage

2018-12-19 Thread Luca Beltrame 
lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17331

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17331: Extend PositionCodec unit tests, better code coverage

2018-12-19 Thread Stefan Brüns 
bruns added a comment.


  Ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17331

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17331: Extend PositionCodec unit tests, better code coverage

2018-12-03 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The test never tested position increments larger than 1, as the positions
  where divided by the docId. Multibyte (i.e. value >= 128) position
  steps where completely omitted.
  
  Use identical datasets in the functional tests and in the benchmarks.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17331

AFFECTED FILES
  autotests/benchmarks/positioncodecbenchmark.cpp
  autotests/unit/codecs/positioncodectest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams