D17419: Add private-mode icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I noticed that the 24px version is now aligned to the grid, but the margins aren't right. The 16 and 22px versions are still not aligned to the grid. The correct margin size

D17419: Add private-mode icon

GB_2 added a comment. Oh, thanks for reminding me about Cuttlefish... I forgot about it, but now I don't need a QML for testing icons anymore :P REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis,

D17419: Add private-mode icon

GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, crozbo,

D17419: Add private-mode icon

ngraham added a comment. Oh, probably a Cuttlefish bug then. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros,

D17419: Add private-mode icon

GB_2 added a comment. How is that even possible? There is no 48 px size icon and the one you showed was and older version of the icon... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf,

D17419: Add private-mode icon

ngraham added a comment. Hmm, now it seems like his hat gets flat at the 48px size: F6464036: flat hat.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis,

D17419: Add private-mode icon

GB_2 updated this revision to Diff 47093. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47081=47093 REVISION DETAIL https://phabricator.kde.org/D17419

D17419: Add private-mode icon

GB_2 added a comment. Is this better? F6463614: private-mode Breeze Icon (2).png F6463613: private-mode.svg REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2,

D17419: Add private-mode icon

ndavis added a comment. I would like if it was more aligned with the grid: See how the top version is a bit more crisp? F6462554: Screenshot_20181207_221001.png F6462556: Screenshot_20181207_221121.png

D17419: Add private-mode icon

GB_2 added a comment. In D17419#372992 , @filipf wrote: > Very Chrome/-ium like :) > > F6462196: image.png > > Maybe expanding the bottom line just a tad more would make it more obvious it's a

D17419: Add private-mode icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great to me! Thanks for embedding the CSS stylesheet too. #falkon or other #VDG folks, any

D17419: Add private-mode icon

ngraham added reviewers: VDG, Falkon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon Cc: filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns,

D17419: Add private-mode icon

filipf added a comment. Very Chrome/-ium like :) F6462196: image.png Maybe expanding the bottom line just a tad more would make it more obvious it's a private eye's hat? REPOSITORY R266 Breeze Icons REVISION DETAIL

D17419: Add private-mode icon

GB_2 updated this revision to Diff 47081. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47078=47081 REVISION DETAIL https://phabricator.kde.org/D17419

D17419: Add private-mode icon

GB_2 created this revision. GB_2 added a reviewer: Breeze. GB_2 added projects: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 401646 F6462086: private-mode Breeze Icon.png