D17430: highlight token strings and delimited strings

[Dominik Haumann]

dhaumann added a comment.


  Also committed, hope everything merged nicely and is correct. I had to update 
the folding unit test data again, but I guess that is fine.
  If you find any issues, please provide another patch :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17430

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2a928919366d: highlight token strings and delimited 
strings (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17430?vs=48636=48638#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17430?vs=48636=48638

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  autotests/folding/highlight.d.fold
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G added a comment.


  In D17430#386026 , @dhaumann wrote:
  
  > Unfortunately, this patch also has an issue:
  >
  >   XSDError in data/syntax/d.xml, at line 413, column 53: Element context is 
missing required attribute lineEndContext.
  >   
  >
  > Can you provide an update to fix it?
  
  
  Done.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G updated this revision to Diff 48636.
aG0aep6G added a comment.


  - add missing lineEndContext attribute

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17430?vs=47371=48636

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[Dominik Haumann]

dhaumann added a comment.


  Unfortunately, this patch also has an issue:
  
XSDError in data/syntax/d.xml, at line 413, column 53: Element context is 
missing required attribute lineEndContext.
  
  Can you provide an update to fix it?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G updated this revision to Diff 47371.
aG0aep6G added a comment.


  - add test lines for token strings and delimited strings

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17430?vs=47115=47371

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aG0aep6G requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  data/syntax/d.xml

To: aG0aep6G
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann