D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi added a comment.


  With respect to bringing this https://phabricator.kde.org/T10279 forward, how 
should I proceed here? Can this go in as first step (after I removed F10 and 
F11)? (see also https://phabricator.kde.org/D17443)

INLINE COMMENTS

> kateview.cpp:700
>  ac->addAction(QStringLiteral("view_dynamic_word_wrap"), a);
> -ac->setDefaultShortcut(a, QKeySequence(Qt::Key_F10));
> +ac->setDefaultShortcuts(a, { QKeySequence(Qt::Key_F10), 
> QKeySequence(Qt::CTRL + Qt::Key_E, Qt::CTRL + Qt::Key_W) });
>  a->setWhatsThis(i18n("If this option is checked, the text lines will be 
> wrapped at the view border on the screen."));

todo: Remove F10

> kateview.cpp:727
>  ac->addAction(QStringLiteral("view_line_numbers"), a);
> -ac->setDefaultShortcut(a, QKeySequence(Qt::Key_F11));
> +ac->setDefaultShortcuts(a, { QKeySequence(Qt::Key_F11), 
> QKeySequence(Qt::CTRL + Qt::Key_E, Qt::CTRL + Qt::Key_L) });
>  a->setWhatsThis(i18n("Show/hide the line numbers on the left hand side 
> of the view."));

todo: remove F11

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, bruns, demsking, sars

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Christoph Cullmann]

cullmann added a comment.


  I have no issues with freeing Fx keys.
  But perhaps we should think about that then in a more extended way: Do we 
really need Fx shortcuts at all for showing the left border stuff?
  People can add them and actually I would assume you once configure that and 
be done with it for the rest of your life.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, bruns, demsking, sars

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi added a comment.


  Yes, those shortcuts exist long time. I would like to change them for these 
specific reasons which I think are worth to be considered:
  
  1. Introduce a default shortcut pair for "Next / Prev Match" which is useful 
and currently missing.
  
  2. "Free" some F keys to have them available for user-defined shortcuts; for 
me that would be those needed for developing (run, debug, stepping, stop and 
what else comes in handy; probably KDevelop would also profit to have F10 and 
F11 freed). I think it is easier for the user to choose one of the F keys for 
those actions than to find a free Ctrl+... combination. At least I have those 
problems regularly when trying to add useful custom shortcuts.
  
  Extended shortcuts are often used in advanced editors and IDEs. I would be 
happy if there are other ideas that would address those issues.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
bruns, demsking, cullmann, sars

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Dominik Haumann]

dhaumann added a comment.


  Hm, these shortcuts exist for 15+ years... The extended shortcuts are not 
used widely in kde at all. Do we really address issues here?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
bruns, demsking, cullmann, sars

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Nathaniel Graham]

ngraham added a comment.


  Oh!
  
  Sorry, please ignore me...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi added a comment.


  In D17442#374054 , @ngraham wrote:
  
  > In D17442#373755 , @gregormi 
wrote:
  >
  > > In D17442#373708 , @ngraham 
wrote:
  > >
  > > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] 
and [Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party 
apps, as well as all GNOME and macOS apps. It might make more sense to 
standardize on those.
  > >
  > >
  > > Just to clarify: F3/Shift+F3 would stay the same, right?
  >
  >
  > Yeah, as backup/additional shortcuts so we don't break workflows for people 
who currently use them.
  
  
  This sounds that we speak of different actions here. This proposal does 
**not** touch the F3/Shift+F3 action which is "Next/Prev result" **from a 
search that was started with Ctrl+F**. It is not my intention to make changes 
there.
  It is about introducing a default shortcut where we currently have none: 
"Goto Next/Prev result item" coming **from a search across multiple files**.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Nathaniel Graham]

ngraham added a comment.


  In D17442#373755 , @gregormi wrote:
  
  > In D17442#373708 , @ngraham 
wrote:
  >
  > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and 
[Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party 
apps, as well as all GNOME and macOS apps. It might make more sense to 
standardize on those.
  >
  >
  > Just to clarify: F3/Shift+F3 would stay the same, right?
  
  
  Yeah, as backup/additional shortcuts so we don't break workflows for people 
who currently use them.
  
  > Currently, Ctrl+G is bound to "Goto line" which is also common in other 
programs (Atom, Sublime, ...). An alternative for "Goto line" could be Ctrl+L 
as in Qt Creator.
  
  Yeah, Ctrl+L is the more common one used in other editors that I'm familiar 
with.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Nathaniel Graham]

ngraham added a comment.


  I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and 
[Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party 
apps, as well as all GNOME and macOS apps. It might make more sense to 
standardize on those.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi edited the summary of this revision.
gregormi added a reviewer: Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gregormi requested review of this revision.

REVISION SUMMARY
  The idea is to use F6 and Shift+F6 in Kate for Next and Previous Search
  Match. These shortcuts are also used by QtCreator for that.
  
  Since F6 is currently used for "Show Icon Border", here is a proposal to
  adapt.
  
  1. Change shortcut for "Show Icon Border" to "Ctrl+E, Ctrl+B" because it
  
  is used not that often to deserve an F key.
  
  Why "Ctrl+E, ..."? Because Qt Creator uses it as start key combination
  for various functions. The alternative would be "Ctrl+D, ..." which is
  used by Visual Studio.
  
  Ctrl+E is currently used for "Go to previous edit" (Ctrl+Shift+E: go to
  next edit). Ctrl+D is currently used to comment a line. I choose to
  change "Go to previous edit".
  
  2. Set new shortcut Alt+F6 and Alt+Shift+F6 for "Go to previous/next
  
  edit".
  
  While at it, I made some additions with the newly freed Ctrl+E shortcut:
  
  3. Add Ctrl+E, Ctrl+W for "Dynamic Word Wrap" (like in Qt Creator) (the
  
  current F10 could be freed later)
  
  4. Use Ctrl+E, Ctrl+I for "Clean Indentation" which is a useful feature
  
  (which could later be extended by a more powerful code formatter)
  
  5. Use Ctrl+E, Ctrl+S for "Show non-printable spaces" (for comparison:
  
  in Qt Creator it is Ctrl+E, Ctrl+V for "Visualize Whitespace")
  
  6. Use Ctrl+E, Ctrl+L for "Show Line Numbers" (as alternative to F11
  
  which could later be used for something else)

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17442

AFFECTED FILES
  src/view/kateview.cpp

To: gregormi
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann