This revision was automatically updated to reflect the committed changes.
Closed by commit R39:765d5674c5e5: use STL were no implicit sharing is required
(authored by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17457?vs=47378=47476
REVISION
cullmann marked an inline comment as done.
cullmann added inline comments.
INLINE COMMENTS
> dhaumann wrote in katetextblock.cpp:64
> Is there a reason why this assert is useless now?
.at() will throw (or abort)
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
cullmann marked 2 inline comments as done.
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17457
To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham,
bruns, demsking, cullmann, sars
dhaumann accepted this revision.
dhaumann added a comment.
Looks still good to me.
INLINE COMMENTS
> katetextblock.cpp:64
> -// in range
> -Q_ASSERT(line < m_lines.size());
> -
Is there a reason why this assert is useless now?
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION
cullmann updated this revision to Diff 47378.
cullmann added a comment.
no copying of cursor sets, only in-place updates
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17457?vs=47377=47378
BRANCH
master
REVISION DETAIL
cullmann updated this revision to Diff 47377.
cullmann added a comment.
This revision is now accepted and ready to land.
STL doesn't need qAsConst
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17457?vs=47376=47377
BRANCH
master
REVISION DETAIL
cullmann planned changes to this revision.
cullmann added a comment.
I will do some more things, therefore one can wait bit with reviewing, beside
if you see some faults ;=)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17457
To: cullmann, dhaumann
Cc:
cullmann updated this revision to Diff 47376.
cullmann added a comment.
more in-place changes instead of copying
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17457?vs=47204=47376
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17457
cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
try to move to STL for some parts that don't want any sharing nor
detaching
TEST PLAN
make &&
