D17460: fixups for `extern` and `pragma`

2019-01-03 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:dc79692de359: fixups for `extern` and `pragma` (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17460?vs=48634=48635#toc REPOSITORY R216 Syntax Highlighting CHANGES

D17460: fixups for `extern` and `pragma`

2019-01-03 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17460#386002 , @dhaumann wrote: > Can you provide an updated patch to fix this? Or at least tell me what lineEndContext should be used here? Fixed, I hope. REPOSITORY R216 Syntax Highlighting BRANCH

D17460: fixups for `extern` and `pragma`

2019-01-03 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 48634. aG0aep6G added a comment. - add missing lineEndContext attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17460?vs=47369=48634 BRANCH extern-and-pragma REVISION DETAIL

D17460: fixups for `extern` and `pragma`

2019-01-03 Thread Dominik Haumann
dhaumann added a comment. @aG0aep6G I just tried to commit this, but it does not work due to the following issue: XSDError in data/syntax/d.xml, at line 613, column 60: Element context is missing required attribute lineEndContext. Can you provide an updated patch to fix this? Or

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17460#374942 , @dhaumann wrote: > Could you also extend the unit test in autotest/input/highlight.d? Done. I also noticed that my last patch broke `version = X;` so I fixed that, too. REPOSITORY R216

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47369. aG0aep6G added a comment. - update test files - fix `version = foo;` - add some more test lines REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17460?vs=47214=47369 BRANCH extern-and-pragma

D17460: fixups for `extern` and `pragma`

2018-12-10 Thread Dominik Haumann
dhaumann added a comment. Could you also extend the unit test in autotest/input/highlight.d? See e.g.: https://github.com/KDE/syntax-highlighting/commit/66367f8e636623a2dbb8ee6add9c7f36683605a2 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17460

D17460: fixups for `extern` and `pragma`

2018-12-09 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY add "Objective-C" linkage type fix `extern(C++)` and add support for `extern(C++, ...)`