D17474: A minor bug in ipv4 and ipv6 test

2018-12-10 Thread Pranav Gade
pranavgade added a comment. In D17474#374522 , @pranavgade wrote: > This change causes the ipv4 address test to fail due to a difference in size of list. > [F6468448 ] D17497: A minor typo in ipv4

D17474: A minor bug in ipv4 and ipv6 test

2018-12-10 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R282:2edc30be9f3e: A minor bug in ipv4 and ipv6 test (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17474?vs=47268&id=47269 REVISION DE

D17474: A minor bug in ipv4 and ipv6 test

2018-12-10 Thread Pranav Gade
pranavgade added a comment. This change causes the ipv4 address test to fail due to a difference in size of list. [F6468448 ] REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17474 To: pranavgade, jgrulich Cc: kde-fram

D17474: A minor bug in ipv4 and ipv6 test

2018-12-10 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17474 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

2018-12-10 Thread Pranav Gade
pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Some QCOMPAREs were comparing a value in a map with itself. Fixed. REPOS