D17474: A minor bug in ipv4 and ipv6 test

[Pranav Gade]

pranavgade added a comment.


  In D17474#374522 , @pranavgade 
wrote:
  
  > This change causes the ipv4 address test to fail due to a difference in 
size of list.
  >  [F6468448 ]
  
  
  D17497: A minor typo in ipv4 test  will 
fix this.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17474

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:2edc30be9f3e: A minor bug in ipv4 and ipv6 test (authored 
by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17474?vs=47268=47269

REVISION DETAIL
  https://phabricator.kde.org/D17474

AFFECTED FILES
  autotests/settings/ipv4settingtest.cpp
  autotests/settings/ipv6settingtest.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

[Pranav Gade]

pranavgade added a comment.


  This change causes the ipv4 address test to fail due to a difference in size 
of list.
  [F6468448 ]

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17474

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Some QCOMPAREs were comparing a value in a map with itself.
  Fixed.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17474

AFFECTED FILES
  autotests/settings/ipv4settingtest.cpp
  autotests/settings/ipv6settingtest.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns