D17498: Xdg Decoration Support

2018-12-21 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:46390781daad: Xdg Decoration Support (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17498?vs=47468&id=47955#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47468&id=47955

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-12 Thread Vlad Zagorodniy 
zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-12 Thread David Edmundson 
davidedmundson updated this revision to Diff 47468.
davidedmundson added a comment.


  remove unused

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47339&id=47468

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> test_xdg_decoration.cpp:104
> +QSignalSpy compositorSpy(m_registry, &Registry::compositorAnnounced);
> +QSignalSpy v6xdgShellSpy(m_registry, 
> &Registry::xdgShellUnstableV6Announced);
> +QSignalSpy xdgShellSpy(m_registry, &Registry::xdgShellStableAnnounced);

Do we need this spy?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson 
davidedmundson marked 5 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson 
davidedmundson updated this revision to Diff 47339.
davidedmundson added a comment.


  zzag's comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47336&id=47339

BRANCH
  xdg_deco

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson 
davidedmundson updated this revision to Diff 47336.
davidedmundson added a comment.


  misc cleanups

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47331&id=47336

BRANCH
  xdg_deco

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> test_xdg_decoration.cpp:178-181
> +
> QTest::addColumn("configuredMode");
> +
> QTest::addColumn("configuredModeExp");
> +QTest::addColumn("setMode");
> +
> QTest::addColumn("setModeExp");

Do we actually use it?

> test_xdg_decoration.cpp:219
> +QVERIFY(shellSurfaceIface);
> +qDebug() << decorationIface->surface();
> +QCOMPARE(decorationIface->surface(), shellSurfaceIface);

Please delete it or provide useful output.

> test_xdg_decoration.cpp:237
> +QVERIFY(modeRequestedSpy.wait());
> +qDebug() << modeRequestedSpy.count();
> +qDebug() << modeRequestedSpy.first().first();

Same here.

> registry.h:665
> + * @see createXdgDecorationManager
> + * @since 5.47
> + **/

since 5.54?

> registry.h:1724
> +/**
> + * Emitted whenever a zxdg_decoration_manger_v1 gets removed.
> + * @param name The name of the removed interface

Typo: manger

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Usual massive boilerplate.
  
  Should allow us to remove the injection in our QPT, as Qt 5.12 implements 
  this protocol directly. Will probably be relevant for other toolkits as
  it's more standardised than our custom one.
  
  Client is mostly 1:1 with the protocol, server side has some tweaking to
  fit with kwayland turning an event based API into a state based one.

TEST PLAN
  Relevant unit test
  Tried in modified kwin with our QPT disabled

REPOSITORY
  R127 KWayland

BRANCH
  xdg_deco

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns