D17500: Restore mobipocket extractor

2019-04-09 Thread Alexander Stippich
astippich updated this revision to Diff 55848. astippich added a comment. - rebase and update - update test - disable mobi extractor REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47335=55848 BRANCH mobi REVISION DETAIL

D17500: Restore mobipocket extractor

2019-01-04 Thread Alexander Stippich
astippich planned changes to this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Restore mobipocket extractor

2018-12-16 Thread Albert Astals Cid
aacid added a comment. I would really like the module to be in the mobipocket repo, would serve as actual proof the extractors outside the main module work if we have an example of it :) INLINE COMMENTS > FindQMobipocket.cmake:1 > +# - Find QMobipocket > +# Find the Qmobipocket library.

D17500: Restore mobipocket extractor

2018-12-14 Thread Luigi Toscano
ltoscano added a comment. In D17500#376854 , @astippich wrote: > In D17500#376221 , @aacid wrote: > > > In D17500#375753 , @astippich wrote: > > > > >

D17500: Restore mobipocket extractor

2018-12-14 Thread Alexander Stippich
astippich added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17500: Restore mobipocket extractor

2018-12-13 Thread Stefan BrĂ¼ns
bruns added a comment. In D17500#376324 , @mgallien wrote: > In D17500#376221 , @aacid wrote: > > > Do I understand that the answer to my "Is it possible to move the extractor to

D17500: Restore mobipocket extractor

2018-12-12 Thread Matthieu Gallien
mgallien added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17500: Restore mobipocket extractor

2018-12-12 Thread Albert Astals Cid
aacid added a comment. In D17500#375753 , @astippich wrote: > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( > Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail

D17500: Restore mobipocket extractor

2018-12-12 Thread Alexander Stippich
astippich added a comment. Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite kio-specific, and a quick look at

D17500: Restore mobipocket extractor

2018-12-11 Thread Albert Astals Cid
aacid added a comment. I'm afraid this could be a bit of a dependency loop since kdegraphics-mobipocket has a thumbnailer that depends on kio which is a tier 3 framework while kfilemetadata is a tier2 framework. Is it possible to move the extractor to kdegraphics-mobipocket instead of

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich updated this revision to Diff 47335. astippich added a comment. - add missing test file REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47334=47335 BRANCH mobi REVISION DETAIL https://phabricator.kde.org/D17500 AFFECTED FILES

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich added a comment. I was unable to get a version check running with cmake, any help is appreciated REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Restore the mobipocket extractor based on the QMobipocket library,