D17530: improve highlighting of complex numbers

2018-12-12 Thread Dominik Haumann
dhaumann added a comment.


  Well, if it's copy & pasted, it must be correct ;)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ea5a88d1df28: improve highlighting of complex numbers 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17530?vs=47430&id=47450

REVISION DETAIL
  https://phabricator.kde.org/D17530

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  data/syntax/c.xml

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Christoph Cullmann
cullmann added a comment.


  It's "stolen" 1:1 from the C++ stuff.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Reviewing correct context popping is always not so easy - I trust this part 
is correct?! ;)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Christoph Cullmann
cullmann added a comment.


  I didn't include rules as I need to rule out the user literal suffixes.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 47430.
cullmann added a comment.


  update unit tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17530?vs=47429&id=47430

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  data/syntax/c.xml

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Christoph Cullmann
cullmann added reviewers: dhaumann, vkrause, Frameworks.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17530: improve highlighting of complex numbers

2018-12-12 Thread Christoph Cullmann
cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  CHANGELOG: support more variants of C number literals
  
  BUG: 402002

TEST PLAN
  adapted unit tests to cover problematic cases

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

AFFECTED FILES
  autotests/input/test.c
  data/syntax/c.xml

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann