This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f4bd4a613187: Reset parentItem when mainItem changes
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17542?vs=47457=49146
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
sometimes in the past i had problems about setting parentitem of an item to
nullptr, due to all the scenegraph nodes of the item being destroyed and
recreated...
somewhere else to do
davidedmundson added a comment.
Oh, to fix fallout from the other review. NM
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D17542
To: broulik, #plasma, mart
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a comment.
What's the benefit?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D17542
To: broulik, #plasma, mart
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise we'll keep piling up custom tooltip items in the dialog. They're