D17593: Notify if a default provider failed to download

2019-01-04 Thread David Faure
dfaure added a comment. The unittest failed. I kind of fixed it (see commit 32a662b ), and my fix works, but it's ugly, it still waits for 5s instead of using that failedToLoad signal. However when requiring the

D17593: Notify if a default provider failed to download

2018-12-19 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D17593 To: apol, #frameworks, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17593: Notify if a default provider failed to download

2018-12-19 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Hm, definitely yes. Frankly i thought this already happened, goes to show what assumptions make of us, eh? ;) REPOSITORY R235 Attica BRANCH master REVISION DETAIL

D17593: Notify if a default provider failed to download

2018-12-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we end up waiting forever without really knowing what happened.