This revision was automatically updated to reflect the committed changes.
Closed by commit R241:211c3a680ea7: Change the path for every item of the
subdirectories in a directory rename (authored by jtamate).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17619?vs=48048=48109#toc
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
jtamate updated this revision to Diff 48048.
jtamate added a comment.
With this version, the test with the patch applied is everlasting in:
while [ true ]; do bin/kdirlistertest testRenameDirectory; if [ $? -ne 0 ];
then break; fi; done
and is still crashing without the patch.
jtamate updated this revision to Diff 48004.
jtamate marked 4 inline comments as done.
jtamate added a comment.
Changes requested done and reduced code duplication.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17619?vs=47995=48004
REVISION DETAIL
jtamate added inline comments.
INLINE COMMENTS
> dfaure wrote in kdirlistertest.cpp:1326
> What's drive_c?
I started this patch following the structure of .wine/drive_c ...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc:
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kdirlistertest.cpp:1326
> +QCOMPARE(m_dirLister.url().toLocalFile(), newDir);
> +QVERIFY(ok);
> +currDir = newDir;
What's drive_c?
>
jtamate updated this revision to Diff 47995.
jtamate added a comment.
Added the unit test. It crashes for me every time without the patch and none
with the patch.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17619?vs=47731=47995
REVISION DETAIL
jtamate added a comment.
I'll work on the unit test this weekend. I don't currently have enough free
time on weekdays.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham,
jtamate retitled this revision from "fix for bug 401552" to "Change the path
for every item of the subdirectories in a directory rename".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel,
