D17629: Add method to BackgroundChecker to add word to session

2018-12-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R246:511a9ba9edc3: Add method to BackgroundChecker to add word to session (authored by ahmadsamir, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17629: Add method to BackgroundChecker to add word to session

2018-12-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R246 Sonnet BRANCH addWordToSession (branched from master) REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsma

D17629: Add method to BackgroundChecker to add word to session

2018-12-29 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 48336. ahmadsamir added a comment. Add doxygen doc for the new method including @since REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=48218&id=48336 BRANCH addWordToSession (branched from master) REVISION

D17629: Add method to BackgroundChecker to add word to session

2018-12-26 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. The old API is lacking docs, too, but could we have some doxygen comment for this with some @since version, too? Thanks. REPOSITORY R246 Sonnet REVISION DETAIL https://

D17629: Add method to BackgroundChecker to add word to session

2018-12-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 48218. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. arc diff verbatim REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=48217&id=48218 BRANCH addWordToSession REVISION DETAIL

D17629: Add method to BackgroundChecker to add word to session

2018-12-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 48217. ahmadsamir added a comment. Fix commit message REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=47683&id=48217 BRANCH addWordToSession REVISION DETAIL https://phabricator.kde.org/D17629 AFFECTED F

D17629: Add method to BackgroundChecker to add word to session

2018-12-22 Thread Martin Tobias Holmedahl Sandsmark
sandsmark accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH addWordToSession REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsmark Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

2018-12-18 Thread Ahmad Samir
ahmadsamir added a reviewer: sandsmark. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsmark Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

2018-12-16 Thread Ahmad Samir
ahmadsamir added a dependent revision: D17630: Don't re-mark words added/ignored to the dictionary as misspelled. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

2018-12-16 Thread Ahmad Samir
ahmadsamir added reviewers: davidedmundson, cullmann. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

2018-12-16 Thread Ahmad Samir
ahmadsamir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Add convience method to add a word to BackgroundChecker the session of the currentDict speller. REPOSITORY R2