This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8c3f000b72ed: Add helper function to disable redirections
(useful for kde-open) (authored by achauvel, committed by aacid).
CHANGED PRIOR TO COMMIT
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17726
To: achauvel, dfaure, #frameworks, cfeck
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns
achauvel updated this revision to Diff 48028.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17726?vs=47986=48028
REVISION DETAIL
https://phabricator.kde.org/D17726
AFFECTED FILES
src/widgets/krun.cpp
src/widgets/krun.h
src/widgets/krun_p.h
To:
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good otherwise.
INLINE COMMENTS
> krun.h:161
> + * @param b wether to follow redirections or not.
> + */
> +void setFollowRedirections(bool b);
Missing @since
yurchor added inline comments.
INLINE COMMENTS
> krun.h:158
> +/**
> + * Sets wether KRun should follow URLs redirections.
> + * This is enabled by default
Typo: wether -> whether
> krun.h:160
> + * This is enabled by default
> + * @param b wether to follow redirections or
ngraham edited the summary of this revision.
ngraham added reviewers: dfaure, Frameworks, cfeck.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17726
To: achauvel, dfaure, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
achauvel created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
achauvel requested review of this revision.
REVISION SUMMARY
See https://phabricator.kde.org/D15189
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17726
